ccotter added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.h:32-33 +private: + const unsigned StrictMode : 1; + const unsigned IgnoreUnnamedParams : 1; +}; ---------------- PiotrZSL wrote: > use bool here, or it could cause some issues, you wont save anything by using > bits. class alignment is already 8. > problem is that you read bools but in storeOptions you store ints, and when > dump-config will be used it will show 1/0 not true/false. > Ah, I happened to see ArgumentCommentCheck.h which seems to be lone check that uses bits... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
