klimek added inline comments. ================ Comment at: include/clang/AST/RecursiveASTVisitor.h:892 @@ -891,1 +891,3 @@ + else + TRY_TO(TraverseStmt(LE->capture_init_begin()[C - LE->capture_begin()])); return true; ---------------- I'd rather pass in the offset than doing math with what's semantically a pointer vs an iterator.
================ Comment at: unittests/Tooling/RecursiveASTVisitorTestExprVisitor.cpp:236 @@ +235,3 @@ +TEST(RecursiveASTVisitor, VisitsLambdaInitCaptureInit) { + { + DeclRefExprVisitor Visitor; ---------------- I'd remove the extra scope. https://reviews.llvm.org/D23204 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits