brad marked 2 inline comments as done. brad added inline comments.
================ Comment at: clang/lib/Basic/Targets/PPC.h:432 + Triple.getOSMajorVersion() >= 13)) || Triple.isOSOpenBSD() || + Triple.isMusl()) + ABI = "elfv2"; ---------------- dim wrote: > clang-format seems to want to format the `if` as: > > ``` > if ((Triple.isOSFreeBSD() && (Triple.getOSVersion().empty() || > Triple.getOSMajorVersion() >= 13)) || > Triple.isOSOpenBSD() || Triple.isMusl()) > ``` > > E,g. it groups the whole FreeBSD expression together. I didn't know it could > do this, but it seems relatively clear. > clang-format seems to want to format the `if` as: > > ``` > if ((Triple.isOSFreeBSD() && (Triple.getOSVersion().empty() || > Triple.getOSMajorVersion() >= 13)) || > Triple.isOSOpenBSD() || Triple.isMusl()) > ``` > > E,g. it groups the whole FreeBSD expression together. I didn't know it could > do this, but it seems relatively clear. I can see both ways of doing things. I try to keep it as compact as possible. But I'll go with the suggested format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144321/new/ https://reviews.llvm.org/D144321 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
