Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:95 + QualType ArgT, BasicValueFactory &BVF, + DescString &Out); + /// Append textual description of a numeric range out of [RMin,RMax] to the ---------------- balazske wrote: > Szelethus wrote: > > Using a `raw_ostream` as a parameter sounds more elegant than a > > `SmallString` with a precise stack buffer length. Not to mention that you > > could call this function with `llvm::errs()` for easy debugging. > I want to improve this in a later patch. The change does involve not new code > too (`getArgDesc` should be changed too and other places where the messages > are generated). Fair enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143194/new/ https://reviews.llvm.org/D143194 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
