xen0n added inline comments.
================ Comment at: llvm/lib/Target/LoongArch/LoongArchMCInstLower.cpp:150 + .getAsInteger(10, Num)) + return false; + AP.emitNops(Num); ---------------- SixWeining wrote: > Seems should return `true`? Consider when verifier is disabled. > > How about handling `PATCHABLE_FUNCTION_ENTER` in `LoongArchAsmPrinter.cpp` > like D140727? I've checked other targets and indeed implementation in `AsmPrinter` is the more widespread approach (RISCV is the outlier here). Let me adjust in one or two days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141785/new/ https://reviews.llvm.org/D141785 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
