NoQ added a comment. In https://reviews.llvm.org/D23300#509665, @xazax.hun wrote:
> In case there is a more complex condition does it only highligh the part that > influenced taking the branch? > > E.g.: > > if (a || b) { // HIghlight only a, if a was true and b was not evaluated > } > Not yet, and this part of things is still broken - perhaps more patches would be needed to address all the issues: F2256900: report-79b22c.html <https://reviews.llvm.org/F2256900> F2256901: report-a71e40.html <https://reviews.llvm.org/F2256901> F2256903: report-245144.html <https://reviews.llvm.org/F2256903> F2256902: report-cf6e19.html <https://reviews.llvm.org/F2256902> The hardest part would be, of course, dealing with `UnknownVal`s and `UndefinedVal`s in conditions, because they are completely ignored by these visitors - after all, no constraints are being added. So we're far from consistency, just some improvements. https://reviews.llvm.org/D23300 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits