jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: clang/test/ClangScanDeps/modules-implementation-vfs.m:67-68 +#import <B/B.h> +struct A { float x; }; // expected-error {{incompatible definitions}} expected-note {{type 'float' here}} +// expected-note@frameworks/A.framework/Headers/A.h:1 {{type 'int' here}} + ---------------- benlangmuir wrote: > jansvoboda11 wrote: > > What purpose does this check serve? > Added a comment to explain this check. Makes sense now, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142501/new/ https://reviews.llvm.org/D142501 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits