scott.linder added inline comments.
================
Comment at: flang/lib/Frontend/FrontendActions.cpp:590
+ std::optional<llvm::CodeGenOpt::Level> OptLevelOrNone =
+ CodeGenOpt::getLevel(CGOpts.OptimizationLevel);
+ assert(OptLevelOrNone && "Invalid optimization level!");
----------------
aaronpuchert wrote:
> Does this need `llvm::`?
>
> ```
> ../llvm-project/flang/lib/Frontend/FrontendActions.cpp:590:7: error: use of
> undeclared identifier 'CodeGenOpt'; did you mean 'llvm::CodeGenOpt'?
> CodeGenOpt::getLevel(CGOpts.OptimizationLevel);
> ^~~~~~~~~~
> llvm::CodeGenOpt
> ../llvm-project/llvm/include/llvm/Support/CodeGen.h:53:13: note:
> 'llvm::CodeGenOpt' declared here
> namespace CodeGenOpt {
> ^
> ```
> See https://lab.llvm.org/buildbot/#/builders/191/builds/13832.
Yes, I just commited a1baa7a5c57ea3065f8f354d2fc758b3328040fd to fix this; I
thought I was building `flang` locally but didn't verify it and clearly was not
Thank you and sorry for the noise!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141968/new/
https://reviews.llvm.org/D141968
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
