benlangmuir added inline comments.
================ Comment at: clang/lib/Lex/Lexer.cpp:4415 + if (Result.isNot(tok::header_name)) + return true; + // Advance the index of lexed tokens. ---------------- This case is missing a test I think. ================ Comment at: clang/lib/Lex/Lexer.cpp:4420 + DepDirectives.front().Tokens[NextDepDirectiveTokenIndex]; + if (BufferStart + NextTok.Offset >= BufferPtr) + break; ---------------- How do we know this will terminate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142143/new/ https://reviews.llvm.org/D142143 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
