kito-cheng added inline comments.
Herald added a subscriber: luke.
================
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:388
+ bool HasVL, PolicyScheme Scheme, const bool HasTailPolicy,
+ const bool HasMaskPolicy, bool SupportOverloading,
bool HasBuiltinAlias, llvm::StringRef ManualCodegen,
----------------
Drop const for parameter, you don't need const qualifier for those primitive
types on the parameter list.
================
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:470
+ const bool HasTailPolicy,
+ const bool HasMaskPolicy, std::string &Name,
+ std::string &BuiltinName,
----------------
Same here.
================
Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:151
+ RVVTypes &Types, bool HasPolicy, Policy PolicyAttrs,
+ const bool HasTailPolicy, const bool HasMaskPolicy);
----------------
Ditto.
================
Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:851
+ PolicyScheme Scheme, const bool HasTailPolicy,
+ const bool HasMaskPolicy, bool SupportOverloading,
bool HasBuiltinAlias, StringRef ManualCodegen,
----------------
Ditto.
================
Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:1008
+ bool IsMasked, bool HasPolicy, const bool HasTailPolicy,
+ const bool HasMaskPolicy, std::string &Name, std::string &BuiltinName,
+ std::string &OverloadedName, Policy &PolicyAttrs) {
----------------
Ditto.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141754/new/
https://reviews.llvm.org/D141754
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
