MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:47
+ Features, [&Args](const Twine &Str) { return Args.MakeArgString(Str); },
+ true);
return true;
----------------
craig.topper wrote:
> `true` -> `/*AddAllExtensions*/true`
The canonical comment is `/*AddAllExtensions=*/true`
================
Comment at: clang/test/Driver/riscv-cpus.c:86
+// MCPU-ABI-SIFIVE-S21: "-target-feature" "+c"
+// MCPU-ABI-SIFIVE-S21: "-target-feature" "+64bit"
// MCPU-ABI-SIFIVE-S21: "-target-abi" "lp64"
----------------
If the two features are adjacent, I suggest you place them one the same line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140693/new/
https://reviews.llvm.org/D140693
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
