Author: Aaron Ballman Date: 2023-01-10T10:44:40-05:00 New Revision: 03b83cd703d403cdfd6f0082423f99aae08d3606
URL: https://github.com/llvm/llvm-project/commit/03b83cd703d403cdfd6f0082423f99aae08d3606 DIFF: https://github.com/llvm/llvm-project/commit/03b83cd703d403cdfd6f0082423f99aae08d3606.diff LOG: Remove a stale FIXME comment; NFC Also regenerates the AST matcher documentation. This matcher is tested in TEST(HasImplicitDestinationType, MatchesSimpleCase) and TEST(HasImplicitDestinationType, DoesNotMatchIncorrectly) in ASTMatchersTraversalTest.cpp. Added: Modified: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h Removed: ################################################################################ diff --git a/clang/docs/LibASTMatchersReference.html b/clang/docs/LibASTMatchersReference.html index 108fc443b0e2..a67b384d537b 100644 --- a/clang/docs/LibASTMatchersReference.html +++ b/clang/docs/LibASTMatchersReference.html @@ -8541,8 +8541,6 @@ <h2 id="traversal-matchers">AST Traversal Matchers</h2> <tr><td>Matcher<<a href="https://clang.llvm.org/doxygen/classclang_1_1ImplicitCastExpr.html";>ImplicitCastExpr</a>></td><td class="name" onclick="toggle('hasImplicitDestinationType0')"><a name="hasImplicitDestinationType0Anchor">hasImplicitDestinationType</a></td><td>Matcher<<a href="https://clang.llvm.org/doxygen/classclang_1_1QualType.html";>QualType</a>> InnerMatcher</td></tr> <tr><td colspan="4" class="doc" id="hasImplicitDestinationType0"><pre>Matches implicit casts whose destination type matches a given matcher. - -FIXME: Unit test this matcher </pre></td></tr> diff --git a/clang/include/clang/ASTMatchers/ASTMatchers.h b/clang/include/clang/ASTMatchers/ASTMatchers.h index a9002895f829..f1b858c511c0 100644 --- a/clang/include/clang/ASTMatchers/ASTMatchers.h +++ b/clang/include/clang/ASTMatchers/ASTMatchers.h @@ -5822,8 +5822,6 @@ AST_MATCHER_P(ExplicitCastExpr, hasDestinationType, /// Matches implicit casts whose destination type matches a given /// matcher. -/// -/// FIXME: Unit test this matcher AST_MATCHER_P(ImplicitCastExpr, hasImplicitDestinationType, internal::Matcher<QualType>, InnerMatcher) { return InnerMatcher.matches(Node.getType(), Finder, Builder); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
