Author: Chuanqi Xu Date: 2023-01-10T10:41:21+08:00 New Revision: 9cb1298dcc85c357eb97ed0bdc3c82c5d011f6f6
URL: https://github.com/llvm/llvm-project/commit/9cb1298dcc85c357eb97ed0bdc3c82c5d011f6f6 DIFF: https://github.com/llvm/llvm-project/commit/9cb1298dcc85c357eb97ed0bdc3c82c5d011f6f6.diff LOG: [NFC] Fix a test faliing in AIX See https://reviews.llvm.org/D140867. The signature of the constructor/destrucor of the global variables is different in different targets. And the CHECKs in the test is unavailable in other targets (e.g., AIX). So the patch tries to avoid the test failure by requiring the target type. Added: Modified: clang/test/CodeGenCXX/pr59765-modules-global-ctor-dtor.cppm Removed: ################################################################################ diff --git a/clang/test/CodeGenCXX/pr59765-modules-global-ctor-dtor.cppm b/clang/test/CodeGenCXX/pr59765-modules-global-ctor-dtor.cppm index 6080786ecd391..64d0b606c6f4f 100644 --- a/clang/test/CodeGenCXX/pr59765-modules-global-ctor-dtor.cppm +++ b/clang/test/CodeGenCXX/pr59765-modules-global-ctor-dtor.cppm @@ -1,4 +1,11 @@ // https://github.com/llvm/llvm-project/issues/59765 +// +// FIXME: Since the signature of the constructors/destructors is +// diff erent in diff erent targets. The current CHECK can't work +// well for other targets like AIX. So here is the REQUIRES. +// It would be better to add the corresponding test for other test. +// REQUIRES: x86-registered-target,aarch64-registered-target +// // RUN: rm -rf %t // RUN: mkdir %t // RUN: split-file %s %t _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
