erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land.
2 quick nits, otherwise LFTM. ================ Comment at: clang/include/clang/Basic/AttrDocs.td:558 + let Content = [{ +A stronger version of ``__attribute__((pure))`` attribute. + ---------------- ================ Comment at: clang/include/clang/Basic/AttrDocs.td:565 +returning a value. They can not write to memory, but may read memory that is +immutable between invocations of the function. + ---------------- A quick sentence somewhere saying HOW this is a 'stronger' version of pure would be a good addition here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits