cor3ntin added inline comments.

================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:125
+                    diag::err_param_default_argument_references_local)
+             << D->getDeclName() << DefaultArg->getSourceRange();
   }
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > `ValueDecl` is a subclass of `NamedDecl` and the diagnostic printer knows 
> > how to properly print those -- I assume this is an NFC change (or near 
> > enough to it).
> Did this one not work the way I expected?
I'm still running the tests, It does seem fine :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137244/new/

https://reviews.llvm.org/D137244

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to