[PATCH] D141192: [Clang] Add warnings on bad shifts inside enums.

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added a comment.

So it looks like in `handleIntIntBinOp` we do hit this code:

  unsigned SA = (unsigned) RHS.getLimitedValue(LHS.getBitWidth()-1);
   if (SA != RHS) {
     Info.CCEDiag(E, diag::note_constexpr_large_shift)
       << RHS << E->getType() << LHS.getBitWidth();

So maybe we should figure out why we decide not to emit this diagnostic and fix 
it there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141192/new/

https://reviews.llvm.org/D141192

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits