hazohelet added a comment.

> So, so long as a string literal still does the suppression, it's probably 
> fine.

I agree with you. I now also think that integer literals _should not_ do the 
warning suppression because programmers are sometimes unsure of the expansion 
result of predefined macros in the compiled environment.
I updated the differential. I am new to Phabricator and made some unnecessary 
operations. Sorry for bothering you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140860/new/

https://reviews.llvm.org/D140860

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to