ChuanqiXu added a comment. @ben.boeckel I updated the test with compilation db. BTW, I am curious that according to https://reviews.llvm.org/D137534, cmake may not use clang-scan-deps with compilation db for P1689 <https://reviews.llvm.org/P1689>. So this is a pure review comment and it is not related with the planned practice of CMake, right? Or did I misunderstand anything?
--- Also I am wondering if cmake will only use clang-scan-deps without compilation db for P1689 <https://reviews.llvm.org/P1689>, how can it generate multiple make-style dependency information into one file. I mean, if we execute: clang-scan-deps -format=p1689 -- clang++ -std=c++20 -MD -MT <target_name> -MF <dep_file> -c input_file <any_other_needed_opts> -o output_file then we execute: clang-scan-deps -format=p1689 -- clang++ -std=c++20 -MD -MT <another_target_name> -MF <dep_file> -c another_input_file <any_other_needed_opts> -o another_output_file the make-style dependency information of `input_file` in <dep_file> will be overwritten. Or would cmake like to concat the results manually? ================ Comment at: clang/test/ClangScanDeps/P1689.cppm:283-294 +// CHECK-MAKE-DAG: [[PREFIX]]/impl_part.o.ddi: \ +// CHECK-MAKE-DAG-NEXT: [[PREFIX]]/impl_part.cppm \ +// CHECK-MAKE-DAG-NEXT: [[PREFIX]]/header.mock +// CHECK-MAKE-DAG: [[PREFIX]]/interface_part.o.ddi: \ +// CHECK-MAKE-DAG-NEXT: [[PREFIX]]/interface_part.cppm +// CHECK-MAKE-DAG: [[PREFIX]]/M.o.ddi: \ +// CHECK-MAKE-DAG-NEXT: [[PREFIX]]/M.cppm ---------------- We can find the result to write make-style dependency information with compilation database here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
