sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Thanks! ================ Comment at: clang-tools-extra/clangd/Compiler.cpp:84 + + // These options only affect the codegen in the backend, and clang will die + // immediately when these files are not existed. ---------------- not sure this is strictly accurate, maybe weaken to "mostly affect codegen, and aren't relevant to clangd" (e.g. the asan options can affect record layout maybe?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140960/new/ https://reviews.llvm.org/D140960 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits