ldionne reopened this revision. ldionne added a comment. This revision is now accepted and ready to land.
In D139938#4008909 <https://reviews.llvm.org/D139938#4008909>, @steven_wu wrote: > In D139938#4008232 <https://reviews.llvm.org/D139938#4008232>, @hans wrote: > >> This seems to have broken the instrprof-darwin-exports.c test, see e.g. >> https://green.lab.llvm.org/green/job/clang-stage1-RA/32351/ >> >> I'll revert for now. > > It seems you still need to claim `OPT_stdlib_EQ` so it doesn't complain about > unused argument when you pass stdlib when compiling C code. Thanks for taking a look. I actually think that the current behavior is correct -- we don't use `-stdlib=libc++` in C mode, and I don't think we should be silencing the warning. If someone compiles C code with `-stdlib=libc++`, I think it's OK to tell them that we're ignoring the flag. Instead, I think the "fix" needs to be done within compiler-rt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139938/new/ https://reviews.llvm.org/D139938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
