jdoerfert added inline comments.
================ Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:584 + std::stringstream typeMod, type; + if (mapTypeBits & 0x04) + typeMod << "always "; ---------------- TIFitis wrote: > kiranchandramohan wrote: > > There is a `bitn` function in `printSynchronizationHint` and > > `verifySynchronizationHint`, can that be used here? > I've added something similar. I got the bit values from Clang codegen and > they use hex so I've kept it that way for uniformity. Let me know if you'd > rather it be in n'th bit format. Clang codegen magic constants (and everything else) is moved to llvm/.../Frontend/OpenMP for a reason. Hardcoding the numbers again somewhere else seems like exactly the wrong thing to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131915/new/ https://reviews.llvm.org/D131915 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
