dblaikie accepted this revision. dblaikie added a comment. In D137059#3989856 <https://reviews.llvm.org/D137059#3989856>, @dblaikie wrote:
> Nathan had a few questions in the cross-project flag naming thread - could > you check/reply to those? I think the right answer is probably "do whatever > -o does" but would be good to verify that behavior makes sense, maybe > explicitly test it in some way if it's significant enough/requires any work > to support getting that behavior? (if it falls out naturally from some > existing file IO handling we have, I'm less worried about testing it > separately) Oh, I guess those questions ^ are really more applicable to the previous patch in the series, that introduces writing the file out anyway - the ability to specify the name of the file probably has no impact/shouldn't have any impact on the answers to the questions, so this patch looks good - please consider those issues in the other patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.llvm.org/D137059 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
