ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
This LGTM.
================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2084-2089
+ // On Apple platforms, C and C++ Standard Library headers are not provided
+ // with the base system. Instead, they are provided in various SDKs for the
+ // different Apple platforms. Clang needs to know where that SDK lives, and
+ // there are a couple ways this can be achieved:
+ //
+ // (1) If `-isysroot <path-to-SDK>` is passed explicitly, use that.
----------------
Instead of this:
> On Apple platforms, C and C++ Standard Library headers are not provided with
> the base system.
I would say this, which is less specific to headers:
> On Apple platforms, standard headers and libraries are not provided with the
> base system (e.g. in `/usr/{include,lib}`).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136315/new/
https://reviews.llvm.org/D136315
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
