erichkeane added inline comments.
================
Comment at: clang/test/Frontend/sarif-reason.cpp:15
+void g() {
+ f1<0>(); // expected-error{{no matching function for call to 'f1'}}
+ f1<S>(); // expected-error{{no matching function for call to 'f1'}}
----------------
cjdb wrote:
> erichkeane wrote:
> > This is definitely a case where I'd love the diagnostics formatted/arranged
> > differently here. If you can use the #BOOKMARK style to make sure errors
> > and notes are together, it would better illustrate what you're trying to do
> > here.
> This is maybe done? I'm not sure if this is the #BOOKMARK style you're
> referring to, but it should capture the same intent. Lemme know if you had
> something else in mind and I'll happily change it 🙂
It isn't exactly (in that it is using line-numbers instead of bookmarks), but
the ordering is fine for me.
The bookmarking is something like:
```
LineThatHasNote; // #NoteLine
...
LineThatCausesError;
// expected-error@-1 {{Some Error}}
// expected-note@#NoteLine {{The Note}}
```
However, what I REALLY care about is that the notes and errors are 'next' to
eachother, since they are easier to read that way
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138939/new/
https://reviews.llvm.org/D138939
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
