jyu2 added inline comments.
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction &CGF, SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool EmitLoc = false); ---------------- jyu2 wrote: > jdoerfert wrote: > > Why the new argument? > Emit error without -g (debug info turn on.) Hi @jdoerfert, Thanks for your review. I added comment on what meaning of EmitLoc as: /// \param EmitLoc emit source location with debug-info is off. Do you mean that is not clear to you? Any suggestion? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139166/new/ https://reviews.llvm.org/D139166 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
