benlangmuir added a comment.
> If the original HeaderSearchOptions didn't have any VFS overlay files, adopt
> the PCM ones.
IIUC this is what the patch does, right?
> If the original HeaderSearchOptions did have VFS overlay files of its own,
> error out if the PCM has different ones.
Where did we land on this on?
================
Comment at: clang/include/clang/Serialization/ASTReader.h:179
+ /// otherwise.
+ virtual bool ReadHeaderSearchPaths(const HeaderSearchOptions &HSOpts,
+ bool Complain) {
----------------
We should document what the expectations are for `ReadHeaderSearchOptions` and
`ReadHeaderSearchPaths` callbacks: will paths be set when
`ReadHeaderSearchOptions` is called? Will non-paths be set when
`ReadHeaderSearchPaths` is called? I assume we want to say "no" so that we're
not tied to callback order, but we should document it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135634/new/
https://reviews.llvm.org/D135634
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
