jansvoboda11 added inline comments.
================ Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:447 + SmallString<128> CanonicalPath = FE.getNameAsRequested(); + ModMapInfo.canonicalizeModuleMapPath(CanonicalPath); + MD.ModuleMapFileDeps.emplace_back(CanonicalPath); ---------------- benlangmuir wrote: > Was this canonicalization necessary? If this is needed can we do it in the > implicit module build so that it is serialized with the correct path? That > seems better for both stability of the implicit module build and avoids > re-canonicalizing the path every time it is scanned. Good question. Canonicalization is not necessary for the test to pass, so I removed it. We can do it during serialization if we discover it's necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135636/new/ https://reviews.llvm.org/D135636 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
