MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Herald added a subscriber: StephenFan.
================ Comment at: clang/test/Driver/zos-profiling-error.c:3 + +// RUN: not %clang -target s390x-none-zos -p -S %s 2>&1 | FileCheck -check-prefix=FAIL-P-NAME %s +// FAIL-P-NAME: error: unsupported option '-p' for target 's390x-none-zos' ---------------- MaskRay wrote: > Prefer `--target=` for new tests. Consider reusing `clang/test/Driver/p.c` > and adding the code to clang/lib/Driver/ToolChains/Clang.cpp instead Sorry, the code is not needed since clang/lib/Driver/ToolChains/Clang.cpp rejects -p for most OSes now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
