tbaeder added inline comments.
================ Comment at: clang/lib/AST/Interp/Descriptor.h:73 + /// Flag indicating if the field is mutable (if in a record). + unsigned IsMutable : 1; + ---------------- shafik wrote: > Maybe `IsFieldMutable` b/c we call `CreateDescriptor` it is a little > confusing why we have `IsConst` and `IsMutable` Agreed, but this code was just moved up in this patch, the field was introduced earlier. ================ Comment at: clang/lib/AST/Interp/Pointer.h:63-64 private: static constexpr unsigned PastEndMark = (unsigned)-1; static constexpr unsigned RootPtrMark = (unsigned)-1; ---------------- shafik wrote: > or `-1u` Alright, but those were not introduced in this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
