aeubanks added inline comments.
================ Comment at: clang/test/Instrumentation/SanitizerBinaryMetadata/common.h:1-3 +#include <stdint.h> +#include <stdio.h> +#include <assert.h> ---------------- tests in `clang/test` cannot assume that standard headers are available, the tests should be hermetic. could you revert and reland with a proper test fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
