eopXD marked 2 inline comments as done. eopXD added inline comments.
================ Comment at: clang/lib/Basic/Targets/RISCV.cpp:195 Builder.defineMacro("__riscv_vector"); + // Currently we support the v0.10 RISC-V V intrinsics + unsigned Version = (0 * 1000000) + (10 * 1000); ---------------- jrtc27 wrote: > eopXD wrote: > > asb wrote: > > > Nit: comment should end with full stop. > > Sorry I just landed the commit and missed this comment. May I ask what do > > yo mean by full stop here? Do you mean a period? > Full stop is British English for what is period in US English, yes Done in https://reviews.llvm.org/rGd8a27ac0e27f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138930/new/ https://reviews.llvm.org/D138930 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits