MaskRay accepted this revision.
MaskRay added inline comments.
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:975
// done on PreLink stage.
- if (!IsThinLTOPostLink)
+ if (!IsThinLTOPostLink) {
addSanitizers(TargetTriple, CodeGenOpts, LangOpts, PB);
----------------
To my self: I'll need to dig up why `if (!IsThinLTOPostLink) {` is here. I
think it's unnecessary. But it's ok to keep KCFI in the same place of
sanitizers.
================
Comment at: llvm/include/llvm/Transforms/Instrumentation/KCFI.h:20
+namespace llvm {
+class TargetMachine;
+
----------------
the declaration is unused now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135411/new/
https://reviews.llvm.org/D135411
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
