jansvoboda11 added inline comments.
================
Comment at: clang/lib/Frontend/HeaderIncludeGen.cpp:289-290
+ SrcMgr::CharacteristicKind NewFileType, FileID PrevFID) {
+ if (!shouldRecordNewFile(NewFileType, SM.getLocForStartOfFile(PrevFID), SM))
+ return;
+
----------------
Hmm, this new logic seems orthogonal to the output format. Changing the set of
headers only based on the desired format seems counter-intuitive. I think we
should either allow specifying the desired logic via a separate command-line
flag, or decouple the new feature from the `-header-include-file` flag
entirely. What are your thoughts?
(Sorry I didn't notice this earlier.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137996/new/
https://reviews.llvm.org/D137996
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
