vaibhav.y added a comment. In D135987#3906253 <https://reviews.llvm.org/D135987#3906253>, @aaron.ballman wrote:
> Thank you for this refactoring, I really like the direction it's going! I've > not spotted anything concerning, but if someone can double-check conformance > to SARIF in terms of the changes to the tests, that would be appreciated. > > It looks like precommit CI found a relevant failure that should be addressed. Thank you! It was the FileCheck tests for -Wsarif-format-unstable. I think I've updated those correctly, but would appreciate another look. I haven't had much experience with FileCheck so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135987/new/ https://reviews.llvm.org/D135987 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
