akhuang added a comment. In D136998#3926368 <https://reviews.llvm.org/D136998#3926368>, @efriedma wrote:
> In D136998#3926321 <https://reviews.llvm.org/D136998#3926321>, @rnk wrote: > >> In D136998#3906874 <https://reviews.llvm.org/D136998#3906874>, @efriedma >> wrote: >> >>> Should we try to use this codepath for variadic lambdas as well? >> >> Yes! >> >>> Do we want to try to unify our cloning code? >>> CodeGenFunction::GenerateVarArgsThunk has code doing something similar. >>> (It's at least worth comparing to see if you're doing something >>> significantly different...) >> >> Good idea >> >> In D136998#3906881 <https://reviews.llvm.org/D136998#3906881>, @efriedma >> wrote: >> >>> Might also be worth considering if we can avoid cloning here. It should be >>> possible to emit the lambda body into a separate function with a calling >>> convention of your choice, and make both the call operator and the static >>> invoker call it. >> >> This would be nice. I wasn't able to provide guidance on how to do that, and >> I think Amy was struggling to synthesize a new method (`__invoke`, `__impl`) >> at the AST layer. > > I think you wouldn't actually synthesize it at all in the AST. > > Basically, the follow code changes: > > 1. Change the mangling of the function that contains the actual lambda body. > 2. Make that function use an alternate calling convention that doesn't > involve inalloca etc. > 3. Synthesize thunks to represent the actual call operator and static invoker. > > This is similar to the way virtual overriding works: there's an actual > function, but there are also alternate entry points that end up in the > vtables. Thanks, that makes sense. I'm not very familiar with thunks but I'll look into it. Would we make a thunk that contains the call to the new lambda body function, and then the invoker and call op functions return that thunk? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
