ChuanqiXu added inline comments.
================
Comment at: clang-tools-extra/clangd/test/completion-modules2.test:13
+export module A;
+void printA() {}
+
----------------
It looks redundant at the first sight. I know we can reduce the size by the
following trick:
```
#ifdef USE_EXPORT
export
#endif
void printA()
...
```
But this style will become very complex soon as long as the the size increases.
An example could be found at:
https://github.com/llvm/llvm-project/blob/main/clang/test/CXX/module/module.interface/p2.cpp.
It was pretty painful for me to understand and edit the test cases. So I don't
like such styles. I prefer the psychology that the somebody's redundancy is
another's clearness. And the redundant test cases looks not a problem to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137693/new/
https://reviews.llvm.org/D137693
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
