MaskRay accepted this revision. MaskRay added a comment. Thanks!
================ Comment at: clang/include/clang/AST/ASTUnresolvedSet.h:73 + void erase(unsigned I) { + if (I == (Decls.size() - 1)) + Decls.pop_back(); ---------------- `if (I == Decls.size() - 1)` ================ Comment at: clang/test/SemaCXX/using-decl-templates.cpp:107 + template <typename T> + struct A + { ---------------- The llvm style prefers `{` at the end of the previous line. Tests usually don't need to follow the convention but the previous code in this test file follows the convention. ================ Comment at: clang/test/SemaCXX/using-decl-templates.cpp:123 + + int + foo () ---------------- `int foo() {` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137263/new/ https://reviews.llvm.org/D137263 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits