reames added a comment. In D137350#3906126 <https://reviews.llvm.org/D137350#3906126>, @craig.topper wrote:
> Do these need their own DecoderNameSpace? What is a decoder namespace? Some quick grepping and googling isn't very informative. ================ Comment at: llvm/lib/Target/RISCV/RISCVInstrFormats.td:148 def OPC_SYSTEM : RISCVOpcode<"SYSTEM", 0b1110011>; +def OPC_CUSTOM3 : RISCVOpcode<"CUSTOM3", 0b1111011>; ---------------- craig.topper wrote: > Since the string here is used for .insn parsing, I think it should be > CUSTOM_3. I'm not sure why we don't already have all 4 added. https://reviews.llvm.org/D137355 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137350/new/ https://reviews.llvm.org/D137350 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
