glider added subscribers: pcc, glider.
glider added inline comments.
================
Comment at: clang/docs/DataFlowSanitizerDesign.rst:54
- /// Returns whether the given label label contains the label elem.
+ /// Returns whether the given label contains the label elem.
int dfsan_has_label(dfsan_label label, dfsan_label elem);
----------------
I believe the word duplication is on purpose here. I'd rewrite the comment as:
```
Returns whether the given label @label contains the label @elem.
```
@pcc, what do you think?
================
Comment at: compiler-rt/include/sanitizer/dfsan_interface.h:65
-/// Returns whether the given label label contains the label elem.
+/// Returns whether the given label contains the label elem.
int dfsan_has_label(dfsan_label label, dfsan_label elem);
----------------
Same as clang/docs/DataFlowSanitizerDesign.rst above.
================
Comment at: compiler-rt/lib/asan/asan_allocator.cpp:1161
// the `pthread_create()` interceptor doesn't wait for the child thread to
- // start before returning and thus loosing the the only live reference to the
+ // start before returning and thus loosing the only live reference to the
// heap object on the stack.
----------------
Ack.
================
Comment at:
compiler-rt/lib/sanitizer_common/tests/sanitizer_stacktrace_test.cpp:211
- // This the the truncation case.
+ // This the truncation case.
ASSERT_GT(actual_len, sizeof(tinybuf));
----------------
Ack.
================
Comment at: compiler-rt/lib/tsan/rtl-old/tsan_interceptors_posix.cpp:2510
// Can't use internal_memcpy, because it copies byte-by-byte,
- // and signal handler reads the handler concurrently. It it can read
+ // and signal handler reads the handler concurrently. It can read
// some bytes from old value and some bytes from new value.
----------------
Ack.
================
Comment at: compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:2529
// Can't use internal_memcpy, because it copies byte-by-byte,
- // and signal handler reads the handler concurrently. It it can read
+ // and signal handler reads the handler concurrently. It can read
// some bytes from old value and some bytes from new value.
----------------
Ack.
================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:540
Type *getShadowTy(Type *OrigTy);
- /// Returns the shadow type of of V's type.
+ /// Returns the shadow type of V's type.
Type *getShadowTy(Value *V);
----------------
Ack.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137338/new/
https://reviews.llvm.org/D137338
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
