vhscampos marked an inline comment as done. vhscampos added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``. ---------------- tschuett wrote: > dmgreen wrote: > > tschuett wrote: > > > What happened with native detection? > > I think I prefer the new wording, FWIW, as we add more CPUs. The native > > detection should just be automatically implied. > But the word `native` disappeared. I've looked at https://reviews.llvm.org/D134352 and also in code related to -mcpu=native implementation and I couldn't find anything related to Neoverse V2. Can you please point me to where that release note relates to? ================ Comment at: llvm/unittests/Support/TargetParserTest.cpp:1083 + AArch64::AEK_SVE | AArch64::AEK_SVE2 | + AArch64::AEK_SVE2BITPERM | AArch64::AEK_SB | + AArch64::AEK_PROFILE | AArch64::AEK_PERFMON | ---------------- dmgreen wrote: > Should SSBS be included in here? As far as I understand it is enabled by > default in 8.5-A. That should mean it's included automatically, but that can > be said for a lot of the other features here too. > Same for AEK_FLAGM, which I noticed as a difference between A715 and X3. SSBS is an optional feature for all Armv8-A architectures. But FlagM should be present here as it's mandatory in v8.4-A. Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
