merrymeerkat added a comment.

In D137077#3896369 <https://reviews.llvm.org/D137077#3896369>, @aaron.ballman 
wrote:

> Thank you for the patch! However, I think this isn't an improvement to the 
> diagnostic -- it's a cute phrase, but it doesn't help the programmer to 
> understand what about their code needs to change.

Hi Aaron! Agreed--thank you for the review! I was just following a tutorial on 
how to make changes to LLVM, so this was not a real code review :)
Cheers!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137077/new/

https://reviews.llvm.org/D137077

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D137077... Dani Ferreira Franco Moura via Phabricator via cfe-commits
    • [PATCH] D1... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D1... Dani Ferreira Franco Moura via Phabricator via cfe-commits
    • [PATCH] D1... Aaron Ballman via Phabricator via cfe-commits

Reply via email to