steakhal added inline comments.
================ Comment at: clang/test/Analysis/svalbuilder-float-cast.c:18-19 *p += 1; // This should NOT be (float)$x + 1. Symbol $x was never casted to float. - // FIXME: Ideally, this should be $x + 1. - clang_analyzer_express(*p); // expected-warning{{Not a symbol}} + clang_analyzer_express(*p); // expected-warning{{$x + 1}} } ---------------- martong wrote: > I think it would make sense to have another RUN line with > `support-symbolic-integer-casts`. In that case I guess we should see > `(int)(float)x` (?). The result remains the same with and without `support-symbolic-integer-casts`. I'll add the RUN lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136603/new/ https://reviews.llvm.org/D136603 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits