shafik added inline comments.
================ Comment at: clang/lib/AST/Interp/Interp.cpp:1 //===--- InterpState.cpp - Interpreter for the constexpr VM -----*- C++ -*-===// // ---------------- Probably a separate NFC commit ================ Comment at: clang/lib/AST/Interp/Interp.cpp:465 +bool CheckCtorCall(InterpState &S, CodePtr OpPC, const Pointer &This) { + assert(!This.isZero()); + const Record *R = This.getRecord(); ---------------- Should we also check `isLive()` or should that just turn into a diagnostic? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136694/new/ https://reviews.llvm.org/D136694 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits