rnk added a comment. In D136474#3888527 <https://reviews.llvm.org/D136474#3888527>, @thakis wrote:
> That sounds good to me, assuming that you have someone concrete in mind for > who "we" is who's removing the irrelevant flags :) But if nobody's in charge > of that at the moment, imho it makes sense to make this default-off until it > no longer regresses determinism. That works for me, I just want to make it clear that the long term goal for the project is that we emit the command line in LF_BUILDINFO by default, rather than disabling it once and for all. If it's not ready yet, great, let's disable it and continue. Over on Linux, this was a frequently requested feature, and you can see that we have -f and -g flags for it. FWIW, we could probably move the terminal detection to the cc1 job. It inherits the TTY, right, so it can do the detection? I would look at how we handle fcolor-diagnostics here as reference, is that in the cc1 line or not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
