dexonsmith added inline comments.
================ Comment at: clang/test/Modules/non-affecting-module-maps-source-locations.m:32 + +// RUN: %clang_cc1 -I %t/first -I %t/second -I %t/third -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache %t/tu.m -o %t/tu.o ---------------- dexonsmith wrote: > This is exercising the code, but it could do one better and check if the > output PCMs are bit-for-bit identical when we (now) expect them to be. > > Maybe you could do this by having two run lines: one that includes `-I > %t/second` and another that doesn't. Then check if the output PCMs are equal. (Or if the PCM isn't bit-for-bit identical yet, maybe at least the AST block should be...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136624/new/ https://reviews.llvm.org/D136624 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
