NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks great to me, thanks!!
================
Comment at:
clang/test/Analysis/std-c-library-functions-arg-constraints-notes.cpp:32-33
__buf_size_arg_constraint_concrete(buf); // \
- // expected-note{{The size of the 1st arg should be equal to or less than
the value of 10}} \
+ // expected-note{{The size of the 1st argument should be equal to or
greater than the value of 10}} \
// expected-warning{{}}
break;
----------------
The warning is the same as the note here right?
Our warnings traditionally describe the problem (the 1st argument *is* less
than 10, and this *is* bad because...), not how things "should" be. I guess we
can think more about that later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101526/new/
https://reviews.llvm.org/D101526
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
