rjmccall added inline comments.
================ Comment at: clang/test/CodeGenObjC/nontrivial-c-struct-property.m:89 + +// CHECK: call void @__destructor_8_s0(ptr %[[AGG_TMP_ENSURED]]) + ---------------- It looks like we're copying `a` into a temporary and then copying out of that temporary into the argument slot. I don't see any reason the extra copy is required. Also, aren't non-trivial structs consumed as arguments? If so, this would be an over-release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136639/new/ https://reviews.llvm.org/D136639 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
