Author: Dan Gohman Date: 2022-10-25T11:44:22-07:00 New Revision: 1e4e2433bcd1a0296ef1043c462252f0d087d90c
URL: https://github.com/llvm/llvm-project/commit/1e4e2433bcd1a0296ef1043c462252f0d087d90c DIFF: https://github.com/llvm/llvm-project/commit/1e4e2433bcd1a0296ef1043c462252f0d087d90c.diff LOG: [WebAssembly] Update supported features in the generic CPU configuration Enable sign-ext and mutable-globals in -mcpu=generic. This makes these features enabled by default. These features are all [finished proposals], and all major wasm engines support them. [finished proposals]: https://github.com/WebAssembly/proposals/blob/main/finished-proposals.md Differential Revision: https://reviews.llvm.org/D125728 Added: clang/test/Driver/wasm-features.c Modified: clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/WebAssembly.cpp Removed: ################################################################################ diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index 93462a16ef8fa..5beaf8e532c91 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -607,6 +607,12 @@ X86 Support in Clang * Support intrinsic of ``__cmpccxadd_epi32``. * Support intrinsic of ``__cmpccxadd_epi64``. +WebAssembly Support in Clang +---------------------------- + +The -mcpu=generic configuration now enables sign-ext and mutable-globals. These +proposals are standardized and available in all major engines. + DWARF Support in Clang ---------------------- diff --git a/clang/lib/Basic/Targets/WebAssembly.cpp b/clang/lib/Basic/Targets/WebAssembly.cpp index e0e7f6a25f2b7..a170a7e9f8cdd 100644 --- a/clang/lib/Basic/Targets/WebAssembly.cpp +++ b/clang/lib/Basic/Targets/WebAssembly.cpp @@ -147,6 +147,9 @@ bool WebAssemblyTargetInfo::initFeatureMap( Features["mutable-globals"] = true; Features["tail-call"] = true; setSIMDLevel(Features, SIMD128, true); + } else if (CPU == "generic") { + Features["sign-ext"] = true; + Features["mutable-globals"] = true; } return TargetInfo::initFeatureMap(Features, Diags, CPU, FeaturesVec); diff --git a/clang/test/Driver/wasm-features.c b/clang/test/Driver/wasm-features.c new file mode 100644 index 0000000000000..e5f71b42b5055 --- /dev/null +++ b/clang/test/Driver/wasm-features.c @@ -0,0 +1,43 @@ +// RUN: %clang --target=wasm32-unknown-unknown -### %s -fsyntax-only 2>&1 | FileCheck %s + +// CHECK: "-fvisibility=hidden" + +// RUN: %clang --target=wasm32-unknown-unknown -### %s 2>&1 | FileCheck %s -check-prefix=DEFAULT +// RUN: %clang --target=wasm32-unknown-unknown -### %s -mcpu=mvp 2>&1 | FileCheck %s -check-prefix=MVP +// RUN: %clang --target=wasm32-unknown-unknown -### %s -mcpu=bleeding-edge 2>&1 | FileCheck %s -check-prefix=BLEEDING-EDGE + +// RUN: %clang --target=wasm32-unknown-unknown -### %s -mbulk-memory 2>&1 | FileCheck %s -check-prefix=BULK-MEMORY +// RUN: %clang --target=wasm32-unknown-unknown -### %s -mno-bulk-memory 2>&1 | FileCheck %s -check-prefix=NO-BULK-MEMORY + +// BULK-MEMORY: "-target-feature" "+bulk-memory" +// NO-BULK-MEMORY: "-target-feature" "-bulk-memory" +// DEFAULT-NOT: "-target-feature" "-bulk-memory" +// MVP-NOT: "-target-feature" "+bulk-memory" +// BLEEDING-EDGE-NOT: "-target-feature" "-bulk-memory" + +// RUN: %clang --target=wasm32-unknown-unknown -### %s -mmutable-globals 2>&1 | FileCheck %s -check-prefix=MUTABLE-GLOBALS +// RUN: %clang --target=wasm32-unknown-unknown -### %s -mno-mutable-globals 2>&1 | FileCheck %s -check-prefix=NO-MUTABLE-GLOBALS + +// MUTABLE-GLOBALS: "-target-feature" "+mutable-globals" +// NO-MUTABLE-GLOBALS: "-target-feature" "-mutable-globals" +// DEFAULT-NOT: "-target-feature" "-mutable-globals" +// MVP-NOT: "-target-feature" "+mutable-globals" +// BLEEDING-EDGE-NOT: "-target-feature" "-mutable-globals" + +// RUN: %clang --target=wasm32-unknown-unknown -### %s -msign-ext 2>&1 | FileCheck %s -check-prefix=SIGN-EXT +// RUN: %clang --target=wasm32-unknown-unknown -### %s -mno-sign-ext 2>&1 | FileCheck %s -check-prefix=NO-SIGN-EXT + +// SIGN-EXT: "-target-feature" "+sign-ext" +// NO-SIGN-EXT: "-target-feature" "-sign-ext" +// DEFAULT-NOT: "-target-feature" "-sign-ext" +// MVP-NOT: "-target-feature" "+sign-ext" +// BLEEDING-EDGE-NOT: "-target-feature" "-sign-ext" + +// RUN: %clang --target=wasm32-unknown-unknown -### %s -mnontrapping-fptoint 2>&1 | FileCheck %s -check-prefix=NONTRAPPING-FPTOINT +// RUN: %clang --target=wasm32-unknown-unknown -### %s -mno-nontrapping-fptoint 2>&1 | FileCheck %s -check-prefix=NO-NONTRAPPING-FPTOINT + +// NONTRAPPING-FPTOINT: "-target-feature" "+nontrapping-fptoint" +// NO-NONTRAPPING-FPTOINT: "-target-feature" "-nontrapping-fptoint" +// DEFAULT-NOT: "-target-feature" "-nontrapping-fptoint" +// MVP-NOT: "-target-feature" "+nontrapping-fptoint" +// BLEEDING-EDGE-NOT: "-target-feature" "-nontrapping-fptoint" _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
