craig.topper added inline comments.
================ Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:814 def SFENCE_VMA : Priv_rr<"sfence.vma", 0b0001001>, Sched<[]>; +let Predicates = [HasStdExtSvinval] in { def SINVAL_VMA : Priv_rr<"sinval.vma", 0b0001011>, Sched<[]>; ---------------- Can we reorder these so there's aren't so many toggles of Predicates. Alternatively, you could add `Requires<[HasStdSvinval]>` to the end of the lines instead of using `let Predicates` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits