phosek added a comment. I wasn't included as a reviewer on D124857 <https://reviews.llvm.org/D124857> and I missed that change so couldn't comment there, but I'm not a fan of including the AIX support in `InstrProfilingPlatformLinux.c`. AIX is neither Linux nor ELF-based and big chunks of that file are now `#ifdef`ed out making it harder to comprehend which part is used where. I'd prefer introducing `InstrProfilingPlatformAIX.c`, moving the AIX-specific logic there, and then figuring out how to possibly share common parts between `InstrProfilingPlatformLinux.c` and `InstrProfilingPlatformAIX.c`, for example by moving them to an `.inc` file.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136192/new/ https://reviews.llvm.org/D136192 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
